> On June 1, 2016, 9:03 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java,
> >  lines 113-114
> > <https://reviews.apache.org/r/47978/diff/1/?file=1399678#file1399678line113>
> >
> >     m_
> 
> Jonathan Hurley wrote:
>     Ugh - didn't mean to make this an "issue"

No problem :)


> On June 1, 2016, 9:03 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java,
> >  lines 415-422
> > <https://reviews.apache.org/r/47978/diff/1/?file=1399675#file1399675line415>
> >
> >     So if the VDF is missing 1 OS family, then fail the whole operatio? 
> > Just making sure this is the correct requirement. For example, if an edge 
> > node has a different OS (like Suse12) then this will fail.

Thanks for the review!  If an edge node is a different OS, yes, we want to fail 
here since ONLY if the VDF doesn't have the version for it.  If the VDF has the 
package-version, then we're good to go.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47978/#review135789
-----------------------------------------------------------


On May 31, 2016, 4:13 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47978/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 4:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
> Luniya.
> 
> 
> Bugs: AMBARI-16933
>     https://issues.apache.org/jira/browse/AMBARI-16933
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The aggregated VDF skips package-version as it is defined in the {{release}} 
> element.  This is incorrect as it implies that information is consistent for 
> all repositories in the VDF.  The element has been moved, so code needs to 
> account for that when formulating commands to the agent.
> 
> Luckily, code already existed for sending down the package-version, so it was 
> changing that code to pull for the correct osFamily.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  f4a615c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  532ab2f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  4ee6670 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/Release.java
>  39b30e7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  f6863be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  69eb39d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  237eed2 
>   ambari-server/src/test/resources/hbase_version_test.xml 183da8c 
> 
> Diff: https://reviews.apache.org/r/47978/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated:
> 
> Tests run: 4370, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 46:24.103s
> [INFO] Finished at: Fri May 27 18:08:19 EDT 2016
> [INFO] Final Memory: 33M/672M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Reply via email to