-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48122/
-----------------------------------------------------------

(Updated June 1, 2016, 1:53 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Changes
-------

updated diff with test cases.


Bugs: AMBARI-16980
    https://issues.apache.org/jira/browse/AMBARI-16980


Repository: ambari


Description
-------

In this patch:
1. the data will continue to be fetched from ATS and DB and merging etc as it 
is today.
2. filtering and sorting will continue to be on client side as it is today.
3. (change) only fetching data based on date filter. Only when the date filter 
changes the jobs will be refetched, but following points will apply.
4. (new) To show the latest state of the jobs, we have a polling from client 
side for refetching the jobs which are not in terminal state. The polling 
interval is 30 secs. This will also be done everytime the "Refresh" button (new 
button) is clicked.
5. (new) if the "To Date" is today then we will also periodically fetch the 
latest jobs from ATS everytime the user switches from any other tab to history 
tab, or when user clicks the "Refresh" button. 
6. The initial date filter will be "last 5 days".


Diffs (updated)
-----

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/utils/ItemNotFound.java
 3b7e51a 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
 f119ff3 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
 34f060d 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleResourceManager.java
 f0eecea 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParser.java
 c4c85ad 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegate.java
 02091f8 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java
 471645d 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/IATSParser.java
 f51b880 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/Job.java
 9afb21a 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerImpl.java
 f6d6ed6 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java
 437c9ba 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobInfo.java
 PRE-CREATION 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/number-range-widget.js
 5d62b59 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js 
8c4ed2f 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
c8bb7d0 
  contrib/views/hive/src/main/resources/ui/hive-web/app/models/job.js 9079b5a 
  contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 
0aa3d41 
  contrib/views/hive/src/main/resources/ui/hive-web/app/services/history.js 
PRE-CREATION 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/history.hbs 
052498e 
  contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
4b9899a 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/ATSParserTest.java
 d8e60c4 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/AggregatorTest.java
 e1f7c7c 

Diff: https://reviews.apache.org/r/48122/diff/


Testing (updated)
-------

updated unit test cases.


Thanks,

Nitiraj Rathore

Reply via email to