> On June 1, 2016, 3:07 a.m., Jayush Luniya wrote:
> > Ship It!

Thanks for the reviews and fo commitying to trunk


- Juanjo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47964/#review135757
-----------------------------------------------------------


On May 27, 2016, 4:36 p.m., Juanjo  Marron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47964/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16850
>     https://issues.apache.org/jira/browse/AMBARI-16850
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for ZOOKEEPER service 
> scripts in common-services
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_windows.py
>  c36e152 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/service_check.py
>  622a5eb 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper.py
>  e0ba54b 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_client.py
>  de4d6e1 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py
>  9f943d7 
> 
> Diff: https://reviews.apache.org/r/47964/diff/
> 
> 
> Testing
> -------
> 
> Passed mvn clean test -DskipSurefireTests
> ZOOKEEPER fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806418/AMBARI-16850.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7006//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7006//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Reply via email to