-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48136/
-----------------------------------------------------------

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-16973
    https://issues.apache.org/jira/browse/AMBARI-16973


Repository: ambari


Description
-------

Ambari server loads properties during server start up. If for some reason the 
json string in the database for a given configType is corrupted, ambari server 
prints an error message saying
"com.google.gson.JsonSyntaxException: 
com.google.gson.stream.MalformedJsonException: Expected EOF at line 1 column 
5319"

The error messsage however does not indicate which configType has the malformed 
JSON string.

This JIRA is to update the exception message to include the configType and the 
corresponding config_id so user knows which one to look at in the database.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
 128fef0 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
dbdd5a2 

Diff: https://reviews.apache.org/r/48136/diff/


Testing
-------

manually patch a trunk cluster, update the clusterconfig table with malformed 
cluster-env configuration. restart ambari server, verify the ambari-server.log 
now has log entries that shows that loading cluster-env config failed due to 
malformed json err and the error message also shows the config_id


Thanks,

Di Li

Reply via email to