> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py,
> >  line 91
> > <https://reviews.apache.org/r/47963/diff/1/?file=1397177#file1397177line91>
> >
> >     @Juanjo, it looks like check_process_status is not imported for YARN 
> > nodemanager and will cause problems. Can you submit an addendum patch with 
> > this change?

Hi Jayush, 
Yes, ill work on fixing it. Can you tell me when you hit this issue for 
verification, please?


- Juanjo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135820
-----------------------------------------------------------


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
>     https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> -------
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Reply via email to