-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48147/
-----------------------------------------------------------

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16991
    https://issues.apache.org/jira/browse/AMBARI-16991


Repository: ambari


Description
-------

After a recent change the AbstractTimelineMetricsSink class has an abstract 
function called getZookeeperQuorum(). If the extending class is returning null, 
then the sink is not working (neither does it if it returns a valid zookeeper 
connection string). Fixed the first issue, now it is working without a 
zookeeper connect string.

Also fixed the name of the misnamed variables called zk_hosts which actually 
contained a zookeper connect string.


Diffs
-----

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 1f86dd0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 6fb0b0e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
 200a603 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
b6301ca 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 076c09c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
 afbccca 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 03ff0ff 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 14125bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 147e148 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 007c357 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
 21c010f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 0a94186 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 a2da737 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 2805b0b 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 0813221 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java
 f814678 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 c382c14 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 ca7ccea 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 6a52708 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 7e649ea 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
 b31f39b 
  ambari-server/src/test/python/stacks/2.4/configs/default.json e01bc26 

Diff: https://reviews.apache.org/r/48147/diff/


Testing
-------

Tested on local cluster.

ambari-logsearch-solr-client:
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

ambari-logsearch-logfeeder:
Tests run: 35, Failures: 0, Errors: 0, Skipped: 0

ambari-server:
Total run:1052
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Reply via email to