-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48134/#review135849
-----------------------------------------------------------


Ship it!




Looks good to me.  Thanks for doing that!

- Tom Beerbower


On June 1, 2016, 4:58 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48134/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 4:58 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton, Sumit Mohanty, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-16961
>     https://issues.apache.org/jira/browse/AMBARI-16961
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> removed LOGSEARCH_SOLR_CLIENT dependency from Atlas stack definition to not 
> force ambari to install the client (if LOGSEARCH service is not used).
> Also I provided a new function in solr_cloud_util to handle permissions on 
> the solr client files (set the same as logsearch uses, then we wont run into 
> any permission issues)
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  b916f19 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  e6e794c 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> d0d73ad 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  a2d78a9 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  573857b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 
> ce2528b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 4890f00 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> faa7350 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json 157fd7e 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 3ad8656 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json e01bc26 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 6839dee 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 0b67405 
> 
> Diff: https://reviews.apache.org/r/48134/diff/
> 
> 
> Testing
> -------
> 
> unit tests done.
> 
> FT: I cannot really test it with HDP 2.5 because on the ATLAS side, in the 
> start script it tries to setup collections anyway, so this patch should be 
> applied with a fresh ATLAS... so, i opened this review request mostly for 
> only review.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to