-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48157/#review135883
-----------------------------------------------------------




ambari-server/src/test/python/stacks/utils/RMFTestCase.py (line 170)
<https://reviews.apache.org/r/48157/#comment200908>

    Reading stack_tools and stack_features from config property instead of 
adding this property in all test jsons.


- Jayush Luniya


On June 1, 2016, 10:59 p.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48157/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 10:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16994
>     https://issues.apache.org/jira/browse/AMBARI-16994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari 2.4.0.0, we will be added stack_features and stack_tools config 
> properties. On upgrade to Ambari 2.4.0.0 these config properties will be 
> automatically added because these are new properties.
> 
> For all future Ambari upgrades above Ambari 2.4+, we should always update 
> these config properties to the latest config property value as defined in the 
> stack. The change here is essentially for future proofing beyond Ambari 
> 2.4.0.0 release.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9a3fa31 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  73c9d97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 59b2db2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
>  334afaf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  2ae5b72 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 807a0e8 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py 9a4dd31 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5 
> 
> Diff: https://reviews.apache.org/r/48157/diff/
> 
> 
> Testing
> -------
> 
> - Verified that upgrade to Ambari 2.4.0.0 adds stack_features and stack_tools 
> config properties
> - Verified that upgrading to Ambari 2.4.1.0 updates stack_features and 
> stack_tools by adding dummy entries.
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Reply via email to