> On June 2, 2016, 12:30 a.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py,
> >  line 38
> > <https://reviews.apache.org/r/48125/diff/1/?file=1403124#file1403124line38>
> >
> >     Should it be "if params.driver_curl_source is not None and ..."? 
> >     
> >     A similar change was made in 
> > "ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py".
> >     
> >     Same comment applies to other changes in this patch which use 
> > "driver_curl_source"

didn't added "params.driver_curl_source is not None" check as it is always 
going to be available in setup_ranger.py, setup_ranger_xml.py and kms.py

Added that logic in setup_ranger_plugin_xml.py because from stack 2.5 onwards 
audit_to_db is not supported by Ranger Service. So ranger supported plugins 
will not download jdbc jar. In all params_linux.py file have :
driver_curl_source = format("{jdk_location}/{jdbc_jar_name}") if 
stack_supports_ranger_audit_db else None


- Mugdha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48125/#review135889
-----------------------------------------------------------


On June 1, 2016, 12:59 p.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48125/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 12:59 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Srimanth Gunturi, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16984
>     https://issues.apache.org/jira/browse/AMBARI-16984
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Copying of jdbc jar for Ranger and Ranger KMS is only done at time of 
> installation and during upgrade of HDP.
> This fix will update the latest jar set by user and delete the previous jar 
> at restart of Ranger and Ranger KMS
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  80e5664 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
>  3dc4914 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  665fa48 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  e446c43 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  03c1258 
> 
> Diff: https://reviews.apache.org/r/48125/diff/
> 
> 
> Testing
> -------
> 
> Tested Ranger and Ranger KMS fresh installation of jdbc jar and then set a 
> newer version of jar and check everything is working fine.
> Tested ambari upgrade.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to