-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/#review135914
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
202)
<https://reviews.apache.org/r/48162/#comment200932>

    I thing the following is a better check since the KERBEROS service may not 
be installed even though Keberos may be enabled.  This can happen if the 
`manual` option is selected rather than `MIT KDC` or `Active Directory`:
    
    ```
    if "cluster-env" in services["configurations"] \
         and "security_enabled" in 
services["configurations"]["cluster-env"]["properties"] \
         and 
services["configurations"]["cluster-env"]["properties"]["security_enabled"].lower()
 == "true":
    ```


- Robert Levas


On June 2, 2016, 1:27 a.m., Josh Elser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48162/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
>     https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix an issue where unsubstituted variables are being left in core-site.xml
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  f887f92 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 5cfe42d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 413a2f7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> d61de7b 
> 
> Diff: https://reviews.apache.org/r/48162/diff/
> 
> 
> Testing
> -------
> 
> Deployed 2.4 with Kerberos and no PQS
> Deployed 2.4 with Kerberos and PQS
> (correct configs for both)
> Python UTs are passing locally
> java UTs still running locally
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Reply via email to