-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48168/#review135969
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 (line 112)
<https://reviews.apache.org/r/48168/#comment200980>

    Typo in "ones", remove the "s"
    Remove the print statement since already have a Logger statement



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 (line 150)
<https://reviews.apache.org/r/48168/#comment200981>

    For robustness, check that hive_jdbc_driver is in 
params.default_connectors_map



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 (line 155)
<https://reviews.apache.org/r/48168/#comment200982>

    Can remove this print statement


- Alejandro Fernandez


On June 2, 2016, 2:28 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48168/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 2:28 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-17007
>     https://issues.apache.org/jira/browse/AMBARI-17007
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  9e298a4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  7657dbc 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  b76bc89 
> 
> Diff: https://reviews.apache.org/r/48168/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to