----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48177/#review135977 -----------------------------------------------------------
ambari-web/app/controllers/installer.js (lines 446 - 447) <https://reviews.apache.org/r/48177/#comment200986> This will never fall to []. App.OperatingSystem.find() will never be falsy even when records are not map to this Ember data class, and so it can be simplified to App.db.setOses(App.OperatingSystem.find().slice()) - Jaimin Jetly On June 2, 2016, 5:48 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48177/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 5:48 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17016 > https://issues.apache.org/jira/browse/AMBARI-17016 > > > Repository: ambari > > > Description > ------- > > Install a cluster. Remove some OSes on step1 of installer. Once the > installation is finished, when you go to edit repo page or ambari admin > versions page, and try to edit the version, you will see the removed OS. > > > Diffs > ----- > > ambari-web/app/controllers/installer.js 36dcfb3 > ambari-web/app/utils/db.js a4e96a0 > > Diff: https://reviews.apache.org/r/48177/diff/ > > > Testing > ------- > > Local ambari-web test passed. > 28632 tests complete (24 seconds) > 154 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
