> On June 2, 2016, 2:33 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml,
> >  lines 155-165
> > <https://reviews.apache.org/r/48157/diff/2/?file=1404583#file1404583line155>
> >
> >     I thought we had a way of saying that you can't override a property ... 
> > marking it final?

These properties dont show up in the UI, however, I have marked them as 
read-only and non-overridable explicitly


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48157/#review135933
-----------------------------------------------------------


On June 2, 2016, 6:15 p.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48157/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 6:15 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16994
>     https://issues.apache.org/jira/browse/AMBARI-16994
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In Ambari 2.4.0.0, we will be added stack_features and stack_tools config 
> properties. On upgrade to Ambari 2.4.0.0 these config properties will be 
> automatically added because these are new properties.
> 
> For all future Ambari upgrades above Ambari 2.4+, we should always update 
> these config properties to the latest config property value as defined in the 
> stack. The change here is essentially for future proofing beyond Ambari 
> 2.4.0.0 release.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  9a3fa31 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  73c9d97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> a36df7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
>  334afaf 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  31556cb 
>   ambari-server/src/test/python/TestVersionSelectUtil.py 807a0e8 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py 9a4dd31 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d 
>   ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5 
> 
> Diff: https://reviews.apache.org/r/48157/diff/
> 
> 
> Testing
> -------
> 
> - Verified that upgrade to Ambari 2.4.0.0 adds stack_features and stack_tools 
> config properties
> - Verified that upgrading to Ambari 2.4.1.0 updates stack_features and 
> stack_tools by adding dummy entries.
> 
> There are a few UT failures in trunk not related to this patch. See 
> https://builds.apache.org/job/Ambari-trunk-Commit/4982/testReport/
> 
> 
> Build Results :
> 
> Failed tests:
>   StackManagerMiscTest.testCycleDetection:70 expected:<[Cycle detected while 
> parsing stack definition]> but was:<[File 
> /Users/jluniya/release/trunk2/ambari/ambari-server/target/test-classes/stacks_with_cycle/OTHER/1.0/services/HDFS/configuration/hdfs-site.xml
>  didn't pass the validation. Error message is : cvc-complex-type.2.4.a: 
> Invalid content was found starting with element 'deletable'. One of 
> '{display-name, filename, deleted, on-ambari-upgrade, on-stack-upgrade, 
> property-type, value-attributes, depends-on, property_depended_by}' is 
> expected.]>
> Tests in error:
>   
> StackManagerTest.initStack:81->createTestStackManager:86->createTestStackManager:103
>  » Ambari
>   ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:48 » Ambari File 
> /Us...
> 
> Tests run: 4394, Failures: 1, Errors: 2, Skipped: 34
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 1:10:35.104s
> [INFO] Finished at: Wed Jun 01 18:14:45 PDT 2016
> [INFO] Final Memory: 38M/1011M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Reply via email to