> On Червень 2, 2016, 6:18 після полудня, Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py,
> >  line 73
> > <https://reviews.apache.org/r/48168/diff/2/?file=1405063#file1405063line73>
> >
> >     If path_to_jdbc is None, should fail here instead of attemping to run 
> > the command, which will have the string "None"

It will not run command with "None". If you will take a look at code below you 
will see this part:

if not os.path.isfile(path_to_jdbc):
  path_to_jdbc = format("{kms_home}/ews/webapp/lib/") + "*"
  error_message = "Error! Sorry, but we can't find jdbc driver with default 
name " + params.default_connectors_map[params.db_flavor] + \
                " in oozie lib dir. So, db connection check can fail. Please 
run 'ambari-server setup --jdbc-db={db_name} --jdbc-driver={path_to_jdbc} on 
server host.'"
  Logger.error(error_message)
  
First of all we check for file existence, path with "None" will return false, 
after that we are trying the last chance and adding all jars from lib, probably 
user renamed jar or put jar to lib by himself. But in the same time we are 
showing Alert message about potential error. I think it's not bad idea and more 
reliable.


- Vitalyi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48168/#review135981
-----------------------------------------------------------


On Червень 2, 2016, 6:04 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48168/
> -----------------------------------------------------------
> 
> (Updated Червень 2, 2016, 6:04 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro 
> Sen.
> 
> 
> Bugs: AMBARI-17007
>     https://issues.apache.org/jira/browse/AMBARI-17007
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> .
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  9e298a4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  908c726 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  7657dbc 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  ffe1783 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  b76bc89 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  e446c43 
> 
> Diff: https://reviews.apache.org/r/48168/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to