----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47746/#review136003 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On June 2, 2016, 10:16 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47746/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 10:16 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: ambari-16017 > https://issues.apache.org/jira/browse/ambari-16017 > > > Repository: ambari > > > Description > ------- > > The latest stable version of Moment.js is 2.13.0. > This task is for updating the version of Moment.js used in > > contrib/views/slider/src/main/resources/ui/vendor/scripts/common/ > ambari-web/vendor/scripts > > > Diffs > ----- > > ambari-web/config.coffee 6ed0915 > ambari-web/karma.conf.js b11cf76 > ambari-web/vendor/scripts/moment.js fe0e19c > ambari-web/vendor/scripts/moment.min.js PRE-CREATION > contrib/views/slider/src/main/resources/ui/config.js 9527393 > contrib/views/slider/src/main/resources/ui/vendor/scripts/common/moment.js > b40374b > > contrib/views/slider/src/main/resources/ui/vendor/scripts/common/moment.min.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/47746/diff/ > > > Testing > ------- > > Manual testing - setting timezone in User Settings. > Slider view - application start time. > > Tests ran clean for ambari-web > > 27834 tests complete (42 seconds) > 154 tests pending > > Tests ran clean for contrib/views/slider > Took 9506ms to run 345 tests. 345 passed, 0 failed. > > > Thanks, > > Sangeeta Ravindran > >
