> On June 2, 2016, 4:59 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py,
> >  line 63
> > <https://reviews.apache.org/r/47941/diff/1/?file=1396056#file1396056line63>
> >
> >     This tarball should be deleted and recreated every time the service is 
> > restarted.

Do you mean the tarball on hdfs should be deleted ? I have one concern that if 
one spark application is running when the service is started (it is possible), 
then it is possile to fail the spark application due to missing of this 
tarball. So I think it would be better to just create and upload this tar only 
when service is configured. I notice hive will upload tarball only in service 
config phase, we might need to that the same way, thoughts ?


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47941/#review135965
-----------------------------------------------------------


On May 27, 2016, 3:33 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47941/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 3:33 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16920
>     https://issues.apache.org/jira/browse/AMBARI-16920
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This a followup ticket for add spark2 stack definition. There's serveral 
> issues:
> 1.  Spark2 thrift server can not started due to miss of 
> spark-thrift-fairscheduler.xml
> 2.  Miss of add spark2 cache file in copy_barball.py
> 3.  Miss the role_commnad_order of spark2
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  286df8d 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  ded9959 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  2eae3e7 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 4a7c1d2 
> 
> Diff: https://reviews.apache.org/r/47941/diff/
> 
> 
> Testing
> -------
> 
> Manually verified.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Reply via email to