> On June 3, 2016, 12:01 a.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py,
> >  line 63
> > <https://reviews.apache.org/r/47941/diff/1/?file=1396056#file1396056line63>
> >
> >     configure() can be called on refresh configs, while the service is 
> > running. What about delete on stop command. A restart will issue a stop 
> > followed by a start.
> >     If a start command fails, a try-catch-finally can do some cleanup and 
> > delete the tarball.
> >     Start command should be a no-op if the service is already running

Just notice copy_to_hdfs has one parameter to allow replace the existing 
tarball, I think I use this api.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47941/#review136015
-----------------------------------------------------------


On May 27, 2016, 3:33 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47941/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 3:33 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16920
>     https://issues.apache.org/jira/browse/AMBARI-16920
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This a followup ticket for add spark2 stack definition. There's serveral 
> issues:
> 1.  Spark2 thrift server can not started due to miss of 
> spark-thrift-fairscheduler.xml
> 2.  Miss of add spark2 cache file in copy_barball.py
> 3.  Miss the role_commnad_order of spark2
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  286df8d 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  ded9959 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  2eae3e7 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 4a7c1d2 
> 
> Diff: https://reviews.apache.org/r/47941/diff/
> 
> 
> Testing
> -------
> 
> Manually verified.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Reply via email to