> On Июнь 3, 2016, 2:34 п.п., Jonathan Hurley wrote:
> > ambari-metrics/ambari-metrics-common/pom.xml, line 89
> > <https://reviews.apache.org/r/47730/diff/5/?file=1405699#file1405699line89>
> >
> >     Can you explain how this works with the relocation pattern below? 
> >     
> >     I get that you're relocating com.google.* classes at the bytecode level 
> > so that they they don't conflict with Guava stuff on the hadoop classpath.
> >     
> >     However, this line seems to indicate that you're also packaging up the 
> > original com.google.common.* classes in your uber JAR. I would think that 
> > this is not desired since you're already relocating (shading) them.

That was new to me. Thank you for the hint.
With no <include>'s , classes are still in the jar

META-INF/maven/com.google.guava/
META-INF/maven/com.google.guava/guava/
META-INF/maven/com.google.guava/guava/pom.properties
META-INF/maven/com.google.guava/guava/pom.xml
org/apache/hadoop/metrics2/sink/relocated/google/common/
org/apache/hadoop/metrics2/sink/relocated/google/common/annotations/
org/apache/hadoop/metrics2/sink/relocated/google/common/annotations/Beta.class
org/apache/hadoop/metrics2/sink/relocated/google/common/annotations/GwtCompatible.class
org/apache/hadoop/metrics2/sink/relocated/google/common/annotations/GwtIncompatible.class
org/apache/hadoop/metrics2/sink/relocated/google/common/annotations/VisibleForTesting.class


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47730/#review136064
-----------------------------------------------------------


On Июнь 3, 2016, 1:54 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47730/
> -----------------------------------------------------------
> 
> (Updated Июнь 3, 2016, 1:54 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16821
>     https://issues.apache.org/jira/browse/AMBARI-16821
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The TimelineMetricsCache implementation in the metrics sink side is currently 
> a ConcurrentSkipListMap. It is better to use pre built cache libraries like 
> Guava that offer more support.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 41ba62e 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  ea7f72d 
>   ambari-project/pom.xml 2fbb1e1 
>   ambari-server/pom.xml 20d3fab 
> 
> Diff: https://reviews.apache.org/r/47730/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to