-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48235/#review136128
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 182)
<https://reviews.apache.org/r/48235/#comment201140>

    better to move these lines higher to after line 149 where the similar logic 
resides ?



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 190)
<https://reviews.apache.org/r/48235/#comment201141>

    are we repeating default values already defined in .xml file ? Would be 
better not to do that, if possible.


- Alexander Denissov


On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48235/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 10:49 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-17023
>     https://issues.apache.org/jira/browse/AMBARI-17023
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Show only relevant properties based on the status of HAWQ Resource Manager.
> When Yarn mode is enable, only two parameters should be invisible.
> hawq_rm_memory_limit_perseg
> hawq_rm_nvcore_limit_perseg
> When standalone mode is enabled, four parameters should be invisible. what 
> you list are correct.
> hawq_rm_yarn_app_name
> hawq_rm_yarn_queue_name
> hawq_rm_yarn_scheduler_address
> hawq_rm_yarn_address
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  3ac4e89 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  28eb82f 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 5750938 
> 
> Diff: https://reviews.apache.org/r/48235/diff/
> 
> 
> Testing
> -------
> 
> yes.
> Now testing 
> /Users/bhuvneshchaudhary/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ
> ~/github/ambari-toolbox/vagrant/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ
>  ~/github/ambari-toolbox/vagrant/ambari
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-06-03 15:50:22,295 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-06-03 15:50:22,301 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-06-03 15:50:22,307 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-06-03 15:50:22,321 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-06-03 15:50:22,333 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized ... 2016-06-03 15:50:22,346 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
> Kerberized ... 2016-06-03 15:50:22,359 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
> Not Kerberized ... 2016-06-03 15:50:22,370 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-06-03 15:50:22,381 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 5: Non HDFS-HA, YARN Resource Management YARN_HA, Not 
> Kerberized ... 2016-06-03 15:50:22,396 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case6 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 6: Non HDFS-HA, YARN Resource Management YARN_HA, 
> Kerberized ... 2016-06-03 15:50:22,407 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case7 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 7: HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-06-03 15:50:22,420 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case8 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 8: HDFS-HA, Standalone Resource Management, 
> Kerberized ... 2016-06-03 15:50:22,431 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case9 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 9: HDFS-HA, YARN Resource Management Non YARN_HA, Not 
> Kerberized ... 2016-06-03 15:50:22,442 - Executing HAWQ Check ...
> ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-06-03 
> 15:50:22,461 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys 
> is either set to false or is not available in hawq-env.xml
> ok
> test_stop_cluster_immediate (test_hawqmaster.TestHawqMaster)
> Run Stop HAWQ Cluster Immediate Mode ... ok
> test_stop_default (test_hawqmaster.TestHawqMaster)
> Run Stop HAWQMASTER ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_activate_hawq_standby (test_hawqstandby.TestHawqStandby)
> Test Activate HAWQ Standby Command ... 2016-06-03 15:50:22,535 - Activating 
> HAWQ standby...
> ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_getHostsForMasterComponent 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_getServiceConfigurationRecommendations 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
> 
> ----------------------------------------------------------------------
> Ran 53 tests in 0.381s
> 
> OK
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Reply via email to