-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48265/#review136231
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js
 (line 149)
<https://reviews.apache.org/r/48265/#comment201259>

    Remove this line instead of commenting it.



ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js
 (line 165)
<https://reviews.apache.org/r/48265/#comment201260>

    same as above


- Oliver Szabo


On June 6, 2016, 8:39 a.m., Dharmesh Makwana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48265/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 8:39 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17052
>     https://issues.apache.org/jira/browse/AMBARI-17052
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains
> 1) When only one tab is selected for comparison then show message to user 
> saying minimum 2 tabs should be selected for comparison.
> 2) Minor fixes.
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/MainLayoutView.js
>  c2e0bb3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/graphs/GraphLayoutView.js
>  79a3a02 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js
>  3290216 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/tabs/HierarchyTabLayoutView_tmpl.html
>  1a3135f 
> 
> Diff: https://reviews.apache.org/r/48265/diff/
> 
> 
> Testing
> -------
> 
> Setup logsearch 2 node cluster and tested the above fixes.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Reply via email to