> On June 3, 2016, 8:16 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml, > > line 32 > > <https://reviews.apache.org/r/48212/diff/1-2/?file=1405757#file1405757line32> > > > > Why are these mandatory property attributes to cause UT failures? > > Shouldnt they have defaults if not defined? > > > > Also how do we decide what to set these properties too? (i.e. > > on-ambari-upgrade add="false" v/s on-ambari-upgrade add="true") Can you > > provide examples? > > > > I am not clear on why on-ambari-upgrade delete="true" and > > on-stack-upgrade delete="false"? > > > > I will look at your original patch to get some context and then review > > later today.
the idea is to force developers to specify what to do during upgrade explicitly when adding properties, instead of trying to guess correct policy during upgrade Regarding documentation - as of now patch causes troubles during RU/EU, and may be partially reverted soon. So let's return to this question later - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/#review136078 ----------------------------------------------------------- On June 3, 2016, 7:55 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48212/ > ----------------------------------------------------------- > > (Updated June 3, 2016, 7:55 p.m.) > > > Review request for Ambari and Jayush Luniya. > > > Bugs: AMBARI-17032 > https://issues.apache.org/jira/browse/AMBARI-17032 > > > Repository: ambari > > > Description > ------- > > {code} > ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 ยป Ambari File > /tm... > {code} > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml > d0acdda > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml > 410a1c1 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml > d84207a > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml > 4a5fbfb > > Diff: https://reviews.apache.org/r/48212/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
