-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48284/#review136310
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
 (lines 101 - 110)
<https://reviews.apache.org/r/48284/#comment201335>

    This statement implies that the problem is that the web client is requests 
all JMX properties in order to figure out only the HAState; should we just 
change what the web client is requesting?



ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
 (line 275)
<https://reviews.apache.org/r/48284/#comment201336>

    This if-statement is not part of the for-loop as it doesn't depend on 
`propertyId`. You can make this checkout outside the loop.


- Jonathan Hurley


On June 6, 2016, 11:35 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48284/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 11:35 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17063
>     https://issues.apache.org/jira/browse/AMBARI-17063
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is a follow-on jira of BUG-53459: when Ambari queries NameNode's HA
> states, currently it retrieves a group of metrics including some unnecessary
> ones that may compete for NameNode lock. It would be better for Ambari to only
> retrieve HA state metrics from NameNode.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXPropertyProvider.java
>  e1a5e22 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java
>  8819991 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java
>  4adea20 
>   ambari-server/src/test/resources/hdfs_namenode_jmx_ha_only.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48284/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to