> On June 6, 2016, 5:31 p.m., Nate Cole wrote:
> > I only see two changes here, and it's just logging.  Was there some missed 
> > files?
> 
> Jonathan Hurley wrote:
>     Same - only 2 changes and they are for logging.
> 
> Dmytro Grinenko wrote:
>     no, as you can see, self.status(env)  would be skipped and this is goal 
> of the patch
> 
> Jonathan Hurley wrote:
>     Ah, I see. So, this change skips status checks during upgrade?
> 
> Nate Cole wrote:
>     Hmm.  We do allow service checks if the upgrade is suspended.  Should 
> that be restricted as well?

yep, this would be perfect solution for 2.4.0 coz upgrade behaviour would be 
consistent with previous releases. While for next releases we can add to *env 
properties some kind of perfect tunning, where to allow this feature. But, 
IMHO, this is dangerous thing during RU.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48287/#review136319
-----------------------------------------------------------


On June 6, 2016, 5:20 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48287/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 5:20 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-17068
>     https://issues.apache.org/jira/browse/AMBARI-17068
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> - deploy latest Ambari 2.4
> - install HDP 2.3 (HIVE and dependencies)
> - update to HDP 2.5
> 
> 
> Error message:
> 
> {code}
> Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py",
>  line 211, in <module>
> HiveServer().execute()
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 257, in execute
> method(env)
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 669, in restart
> raise Fail("Stop command finished but process keep running.")
> resource_management.core.exceptions.Fail: Stop command finished but process 
> keep running.
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestScript.py adb8501 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 61759cc 
> 
> Diff: https://reviews.apache.org/r/48287/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to