> On June 3, 2016, 11:34 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py, > > line 94 > > <https://reviews.apache.org/r/48234/diff/1/?file=1406209#file1406209line94> > > > > How could upgrade_type be None in "pre_upgrade"restart" ?
upgrade_type defaults to None if the caller doesn't specify it. This is done by script.py I prefer robust coding - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48234/#review136136 ----------------------------------------------------------- On June 6, 2016, 8:04 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48234/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 8:04 p.m.) > > > Review request for Ambari, Andrew Onischuk, Di Li, Dmitro Lisnichenko, > Jonathan Hurley, Jayush Luniya, Nate Cole, and Tim Thorpe. > > > Bugs: AMBARI-17037 > https://issues.apache.org/jira/browse/AMBARI-17037 > > > Repository: ambari > > > Description > ------- > > Fresh installation and EU/RU of Falcon is failing. > In HDP 2.4, Falcon used the data mirroring folder. > In HDP 2.5, data mirroring is no longer used and instead uses the extensions > folder that must be uploaded to HDFS. > > This means that EU/RU from HDP 2.4 to 2.5 must also upload the extensions > folder to HDFS > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 34d1a1a > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > 4c13aaa > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 5e25325 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py > 7c2cdf4 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 8c2ad8e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 8b669e8 > ambari-server/src/test/python/stacks/2.0.6/configs/default.json 8d04e36 > > Diff: https://reviews.apache.org/r/48234/diff/ > > > Testing > ------- > > Python unit tests passed. > > ---------------------------------------------------------------------- > Total run:1052 > Total errors:0 > Total failures:0 > OK > > Express Upgrade is currently broken, so will commit this patch and retest > once it is stable again in Hadoop Core. > > > Thanks, > > Alejandro Fernandez > >
