-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48325/
-----------------------------------------------------------

(Updated June 7, 2016, 10:52 a.m.)


Review request for Ambari, Daniel Gergely, Oliver Szabo, and Sebastian Toader.


Changes
-------

added missing brackets


Bugs: AMBARI-17004
    https://issues.apache.org/jira/browse/AMBARI-17004


Repository: ambari


Description
-------

Some unit tests are failing because they depend on the order elements are 
returned by the iterator of a HashSet/HashMap. Usually they are small (2-3 
entries), so they may easily produce good results. Still in other environments 
they fail as the order the elements are returned from a HashSet/HashMap may 
depend on the JVM used.

The issues are elaborated in the comments of the bug.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestAuditEventCreatorHelper.java
 f7a6e36 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/PrivilegeEventCreatorTest.java
 ff4abd6 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java
 18e2d3f 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/ViewPrivilegeEventCreatorTest.java
 ab2b068 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java
 d299fad 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
 fbe233d 

Diff: https://reviews.apache.org/r/48325/diff/


Testing
-------

Tests are running fine now even on my computer which wasn't true before. They 
failed some times on Jenkins too.


Thanks,

Miklos Gergely

Reply via email to