-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48338/#review136454
-----------------------------------------------------------


Fix it, then Ship it!




Looks fine overall, but I would recommend adding the new LogSearch properties 
to the Ambari Stack definition in this patch. 

Thanks.


ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 (line 38)
<https://reviews.apache.org/r/48338/#comment201506>

    It looks like all these properties should be defined in the "LOGSEARCH" 
stack definitions in Ambari, so I'd recommend adding them in this patch.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 (line 41)
<https://reviews.apache.org/r/48338/#comment201505>

    Minor issue: looks like a typo here, the property should probably be 
spelled:
    
    "logsearch.https.keystore.password"



ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
 (line 53)
<https://reviews.apache.org/r/48338/#comment201507>

    I would definitely recommend that all these properties be added to the 
stack definition for LOGSEARCH.  Without the stack changes, Ambari won't be 
able to uptake this configuration option. 
    
    Thanks.


- Robert Nettleton


On June 7, 2016, 12:25 p.m., Dharmesh Makwana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48338/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 12:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17092
>     https://issues.apache.org/jira/browse/AMBARI-17092
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> LogSearch portal should support HTTPS to ensure secure communication
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  2ebf981 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/PropertiesUtil.java
>  f31e8f8 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  f477c5a 
> 
> Diff: https://reviews.apache.org/r/48338/diff/
> 
> 
> Testing
> -------
> 
> Setup Logsearch on 3 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Reply via email to