-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48332/#review136456
-----------------------------------------------------------


Fix it, then Ship it!




The patch looks fine to me, but I do have a question below about NiFi support 
in general.

Since Apache NiFi support has not yet been added to Ambari, it seems confusing 
to add the LogSearch support for it first. 

Thanks.


ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 (line 233)
<https://reviews.apache.org/r/48332/#comment201509>

    Is NiFi being added to Ambari in 2.4?  
    
    If so, is there a patch for those changes being reviewed as well?


- Robert Nettleton


On June 7, 2016, 10:05 a.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48332/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 10:05 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17086
>     https://issues.apache.org/jira/browse/AMBARI-17086
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Giving users the ability to deploy a service to their cluster to collect, 
> index, and explore those log files is needed to improve the ease of 
> administration for the operators.
> Add Log search capability for NiFi
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  34583ba 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-nifi.json.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48332/diff/
> 
> 
> Testing
> -------
> 
> Log Seaerch was installed and logs were loaded fine on local cluster with NiFi
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to