-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48321/#review136457
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for providing this patch.

I do have one question listed as an issue below that I think should be resolved 
prior to merging this.

I'd recommend asking Aravindan to review the code and my question, just to 
clarify what this property's value can be in a multi-collector environment. 

Thanks again!


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 (line 2623)
<https://reviews.apache.org/r/48321/#comment201510>

    I'm a little unsure about this change.
    
    On the surface, this appears to be correct in terms of resolving the 
Exception, but my concern here is that we're not exactly sure what the value of 
this property should be when more than 1 Metrics Collector is deployed.
    
    I would recommend asking a Metrics expert about this. 
    
    Basically, can the
    
    "timeline.metrics.service.webapp.address" property be used in a 
multi-collector environment?  If so, is the value expected to be a 
comma-separated list of collectors?


- Robert Nettleton


On June 7, 2016, 8:12 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48321/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 8:12 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, Robert 
> Nettleton, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17082
>     https://issues.apache.org/jira/browse/AMBARI-17082
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If blueprint contains 2 AMS collectors, Ambari server failed to start 
> METRICS_COLLECTOR with
> 
> ERROR [pool-16-thread-1] TopologyManager:782 - 
> TopologyManager.ConfigureClusterTask: An exception occurred while attempting 
> to process cluster configs and set on cluster:
> java.lang.IllegalArgumentException: Unable to update configuration property 
> 'timeline.metrics.service.webapp.address' with topology information. 
> Component 'METRICS_COLLECTOR' is mapped to an invalid number of hosts '2'.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  a0af813 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  8b1a9a6 
> 
> Diff: https://reviews.apache.org/r/48321/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to