-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48345/#review136520
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On June 7, 2016, 1:35 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48345/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 1:35 p.m.)
> 
> 
> Review request for Ambari and John Speidel.
> 
> 
> Bugs: AMBARI-14887 and AMBARI-17031
>     https://issues.apache.org/jira/browse/AMBARI-14887
>     https://issues.apache.org/jira/browse/AMBARI-17031
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When deploying a blueprint that specified ha enabled 
> (atlas.server.ha.enabled=true), the atlas.server.address.id1, 
> atlas.server.address.id2 (etc) needs to be replaced with the hostnames for 
> the host group. This does not occur today, instead the 
> atlas.server.address.id1 is tokenized with (for example): 
> atlas.server.host.id1: "server_hosts", which is not quite correct. I believe 
> the blueprint runtime generator needs to create the proper entries with a 
> different token that is replaced with each host where Atlas server is 
> deployed.
> 
> Also remove topology related configuration variables from params.py and move 
> them to the stack advisor.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  a0af813 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  1d40ae1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  98cbc30 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 4b1926a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  8b1a9a6 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 74297de 
> 
> Diff: https://reviews.apache.org/r/48345/diff/
> 
> 
> Testing
> -------
> 
> Add new blueprint unit tests.  Updated stack advisor unit tests.
> 
> manual test deployment with Atlas / HA.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Reply via email to