> On June 8, 2016, 1:08 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py,
> >  line 61
> > <https://reviews.apache.org/r/47941/diff/2/?file=1408197#file1408197line61>
> >
> >     This is calling what's meant to be a private function and getting the 
> > element at index 1 without checking the length.
> >     
> >     Rename the function by removing the leading "_" and check the length 
> > before accessing [1]

This method return a tuple, so I think it is not necessary to check the length. 
If the length is incorrect, then must be something wrong, the installation 
should not continue.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47941/#review136568
-----------------------------------------------------------


On June 7, 2016, 6:16 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47941/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 6:16 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16920
>     https://issues.apache.org/jira/browse/AMBARI-16920
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This a followup ticket for add spark2 stack definition. There's serveral 
> issues:
> 1.  Spark2 thrift server can not started due to miss of 
> spark-thrift-fairscheduler.xml
> 2.  Miss of add spark2 cache file in copy_barball.py
> 3.  Miss the role_commnad_order of spark2
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  286df8d 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  3316f78 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  2eae3e7 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 1b33345 
> 
> Diff: https://reviews.apache.org/r/47941/diff/
> 
> 
> Testing
> -------
> 
> Manually verified.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Reply via email to