-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48147/
-----------------------------------------------------------

(Updated June 8, 2016, 11:09 a.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and 
Sid Wagle.


Changes
-------

Removed zk-connect-string name fixes.


Bugs: AMBARI-16991
    https://issues.apache.org/jira/browse/AMBARI-16991


Repository: ambari


Description (updated)
-------

After a recent change the AbstractTimelineMetricsSink class has an abstract 
function called getZookeeperQuorum(). If the extending class is returning null, 
then the sink is not working (neither does it if it returns a valid zookeeper 
connection string). Fixed the first issue, now it is working without a 
zookeeper connect string.


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 ca7ccea 

Diff: https://reviews.apache.org/r/48147/diff/


Testing (updated)
-------

Tested on local cluster.

ambari-metrics-common:
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Miklos Gergely

Reply via email to