> On June 8, 2016, 7:47 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java, > > lines 347-351 > > <https://reviews.apache.org/r/48440/diff/1/?file=1411499#file1411499line347> > > > > If this is needed in UpgradeCatalog240, why is it being done in > > UpgradeCatalog230? > > Eugene Chekanskiy wrote: > it doesn't matter where to put this hack, just after data was added or in > the beginning of 240 upgrade catalogue, so maybe its better to keep 240 > catalog clean?
also I think thats it's better to keep this kind of hacks close to data, for example 230 ambari upgrade to 240 upgrade doesn't need this hack at all(other thing - we don't have ambari 230 :)) - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48440/#review136677 ----------------------------------------------------------- On June 8, 2016, 6:51 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48440/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 6:51 p.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: AMBARI-17128 > https://issues.apache.org/jira/browse/AMBARI-17128 > > > Repository: ambari > > > Description > ------- > > Login to cluster using credentials of a cluster operator/ServiceAdministrator. > Try moving to alerts page. Alerts are editable by cluster operator when it > shouldn't have been. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java > ec3d765 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > b0f4974 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e89c0f1 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f640bb6 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0057982 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6a98e84 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > df8f315 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql caee4f6 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql ffd2040 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 86d776d > > Diff: https://reviews.apache.org/r/48440/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
