-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48460/#review136793
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 767)
<https://reviews.apache.org/r/48460/#comment201879>

    Why is this changed. Seems like a rebase issue.



ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
 (line 46)
<https://reviews.apache.org/r/48460/#comment201880>

    Make these final static.



contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties (line 
24)
<https://reviews.apache.org/r/48460/#comment201881>

    Enclose this withing some marker like a '[]' to separate it out from rest 
of the logs


- DIPAYAN BHOWMICK


On June 9, 2016, 5 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48460/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17135
>     https://issues.apache.org/jira/browse/AMBARI-17135
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> added servlet filter and used Logging frameworks MDC feature to insert view 
> related information from URL. Updated view log4j files for the same.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  961b6fe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/AmbariViewsMDCLoggingFilter.java
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties 
> 32903d3 
>   contrib/views/files/src/main/resources/view.log4j.properties 698947e 
>   contrib/views/hive-next/src/main/resources/view.log4j.properties b1bd5f2 
>   contrib/views/hive/src/main/resources/view.log4j.properties 16c2d0e 
>   contrib/views/hueambarimigration/src/main/resources/view.log4j.properties 
> 3e959e7 
>   contrib/views/jobs/src/main/resources/view.log4j.properties 86687d6 
>   contrib/views/pig/src/main/resources/view.log4j.properties 5b23a48 
>   contrib/views/slider/src/main/resources/view.log4j.properties 4737032 
>   contrib/views/storm/src/main/resources/view.log4j.properties 309df8d 
>   contrib/views/tez/src/main/resources/view.log4j.properties 08e00bd 
>   contrib/views/zeppelin/src/main/resources/view.log4j.properties 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48460/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Reply via email to