-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48436/#review136800
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
 (lines 76 - 81)
<https://reviews.apache.org/r/48436/#comment201885>

    Should this be a parameter of the alert definition?


- Nate Cole


On June 8, 2016, 2:24 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48436/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 2:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-17127
>     https://issues.apache.org/jira/browse/AMBARI-17127
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If the Ambari Server is restarted after being down for several minutes, the 
> "Ambari Server Performance" alert will trigger as being stale. This is 
> because the {{StaleAlertRunnable}} is not checking to ensure that Ambari has 
> been up and running long enough to have run the alert.
> 
> The {{StaleAlertRunnable}} should verify that the uptime of Ambari is greater 
> than staleness interval.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java
>  cf12bbf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/StaleAlertRunnableTest.java
>  9a9d989 
> 
> Diff: https://reviews.apache.org/r/48436/diff/
> 
> 
> Testing
> -------
> 
> Failure not related to patch.
> 
> Failed tests: 
>   ViewPrivilegeEventCreatorTest.putTest:85 expected:<...missions(
> Permission[1: 
>   Users: testuser
>   Groups: testgroup
> Permission2: 
>   Users: testuser2])> but was:<...missions(
> Permission[2: 
>   Users: testuser2
> Permission1: 
>   Users: testuser
>   Groups: testgroup])>
> 
> Tests run: 4468, Failures: 1, Errors: 0, Skipped: 34
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 34:11 min
> [INFO] Finished at: 2016-06-08T01:10:29-04:00
> [INFO] Final Memory: 38M/645M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to