----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136799 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java (lines 190 - 193) <https://reviews.apache.org/r/48266/#comment201883> Instead of picking only the first report from the reports collection iterate through the reporst and publish the HeartbeatProcessingFinishedEvent for all clusters found in the reports. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java (lines 116 - 120) <https://reviews.apache.org/r/48266/#comment201884> There is no need for this public static field. ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java (line 147) <https://reviews.apache.org/r/48266/#comment201886> There is a findByClusterId method that returns the topology requests for a given cluster. ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java (line 149) <https://reviews.apache.org/r/48266/#comment201887> You could ```TopologyRequest.Type.PROVISION == TopologyRequest.Type.valueOf(entity.getAction())``` ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java (line 167) <https://reviews.apache.org/r/48266/#comment201893> Once a cluster creation request finished for a cluster we should not track any more that cluster id. ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java (line 168) <https://reviews.apache.org/r/48266/#comment201891> We should log something like "Cluster creation request X using Blueprint Y successfully completed !" for success. In case of failure "Cluster creation request X using Blueprint Y failed !" - Sebastian Toader On June 9, 2016, 2:54 p.m., Daniel Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48266/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 2:54 p.m.) > > > Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Nettleton, > Sandor Magyari, Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-17053 > https://issues.apache.org/jira/browse/AMBARI-17053 > > > Repository: ambari > > > Description > ------- > > Add a log message to see when the cluster is ready to use (cluster creation > finishes). > > An event after each heartbeat. At that time cluster provision request is > checked if it is finished or not. In case of an ambari server restart, the > replayed requests are used to determine which one was the provision request. > I could not find a nice way to do it, but I could make a workaround. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > c6036c2 > > ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java > 1079806 > > ambari-server/src/main/java/org/apache/ambari/server/events/HeartbeatProcessingFinishedEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java > 77419d8 > > ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java > 324a397 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > e3f5b49 > > ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java > fd8653c > > Diff: https://reviews.apache.org/r/48266/diff/ > > > Testing > ------- > > Still running locally... > > > Thanks, > > Daniel Gergely > >
