-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48403/#review136808
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On June 9, 2016, 9:12 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48403/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 9:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jonathan 
> Hurley, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17112
>     https://issues.apache.org/jira/browse/AMBARI-17112
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We decided to split changes to stack config xmls and processing of them into 
> few patches.
> Current patch changes validation rules and available fields
> 
> Splitted PropertyUpgradeBehavior into 2 classes.
> PropertyAmbariUpgradeBehavior - defines behavior for ambari upgrade.
> on-ambari-upgrade now has the same 3 attributes, but all are optional. 
> Default value for add is true, false for others.
> 
> PropertyStackUpgradeBehavior - defines behavior for stack upgrade.
> on-stack-upgrade now has one attribute - add, and it is required.
> 
> Modified property update script and xsd schema to satisfy new requirements.
> 
> If patch looks good, I'll modify all stack configs to comply with it and 
> commit both patches at the same time.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
> fba2daa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
>  de2e342 
>   
> ambari-server/src/main/resources/scripts/configurations-set-default-update-policy.sh
>  930f778 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
>  9a3d195 
> 
> Diff: https://reviews.apache.org/r/48403/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to