-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48508/
-----------------------------------------------------------

(Updated June 10, 2016, midnight)


Review request for Ambari, Dmytro Sen and Sumit Mohanty.


Changes
-------

Fixed review issues.


Bugs: AMBARI-17149
    https://issues.apache.org/jira/browse/AMBARI-17149


Repository: ambari


Description
-------

HadoopTimelineMetricsSink has an ExecutorService thread which is not a daemon 
thread. 

The executor is not shutdown, and thread is not interrupted while the sink 
stops. This causes region server process to hang although the rest of the 
threads have all exited. The new thread should be marked as a daemon thread, 
and also call shutdown() or shutdownNow() on the executor in sink close.


Diffs (updated)
-----

  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 0580088 

Diff: https://reviews.apache.org/r/48508/diff/


Testing
-------

Manually tested. Unit tests pass.


Thanks,

Aravindan Vijayan

Reply via email to