-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48486/#review137048
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 (line 305)
<https://reviews.apache.org/r/48486/#comment202182>

    What I meant was the java labeling, like this:
    
    mainCycle: while (true)
    ...
    writeCycle: while (!isDrain())
    ...
    continue writeCycle
    ...
    break mainCycle
    
    see https://docs.oracle.com/javase/tutorial/java/nutsandbolts/branch.html


- Miklos Gergely


On June 10, 2016, 5:53 p.m., Don Bosco Durai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48486/
> -----------------------------------------------------------
> 
> (Updated June 10, 2016, 5:53 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17136
>     https://issues.apache.org/jira/browse/AMBARI-17136
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In addition to IOException, now also considering SolrException also has 
> transient errors. In addition, now not relying on Ping to check whether Solr 
> is up. The reason being, Solr might be up, but the collection/shard might not 
> be available.
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  6fb0b0e 
> 
> Diff: https://reviews.apache.org/r/48486/diff/
> 
> 
> Testing
> -------
> 
> Created 3 node hadoop cluster and tested this patch
> 
> 
> Thanks,
> 
> Don Bosco Durai
> 
>

Reply via email to