> On June 10, 2016, 7:16 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > lines 146-149 > > <https://reviews.apache.org/r/48561/diff/1/?file=1415174#file1415174line146> > > > > Instead of executing this under "supports_falcon_extensions" should it > > be under an > > > > `if not params.supports_data_mirroring:`
Actually, if DR is supported, it should be a copy. If extensions is supported, then Falcon jsut needs Ambari to create an empty directory. Stack teams should really own these scripts. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48561/#review137059 ----------------------------------------------------------- On June 10, 2016, 9 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48561/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 9 p.m.) > > > Review request for Ambari, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Tim Thorpe. > > > Bugs: AMBARI-17171 > https://issues.apache.org/jira/browse/AMBARI-17171 > > > Repository: ambari > > > Description > ------- > > If Falcon extensions is supported, Ambari still needs to create the > /apps/data-mirroring directory in HDFS. > Also, RU/EU does not need to explicitly create the extensions directory in > the pre_upgrade_restart function since the start function will create it. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > b5b3a34 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py > 0d2cd8e > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 41954a5 > > Diff: https://reviews.apache.org/r/48561/diff/ > > > Testing > ------- > > Ran python unit tests, > > Total run:1055 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
