> On June 10, 2016, 1:40 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 889
> > <https://reviews.apache.org/r/48549/diff/1/?file=1414725#file1414725line889>
> >
> >     hosts="all" is the default, you can remove it.
> >     sequential="true" isn't needed since it is only useful when two 
> > consecutive tasks need to run one after the other even though they are on 
> > different hosts.
> >     
> >     Why is there a stop and start in post-upgrade?
> >     What are you trying to achieve here?
> >     
> >     Pre-upgrade is any steps to execute before restarting the component, 
> > Post-upgrade is after restarting. So if there are any other stop-start 
> > steps, it means the component is being restarted twice!
> 
> Nate Cole wrote:
>     I agree with Alejandro here, it looks like you're stopping all admins, 
> java-patching only one, then starting them all.  They should all need 
> patching, no?  And if that's the case that can all be handled on the python 
> side with nothing but restart for the component in the UP.

I think that stopping all and running the patch on 1 is correct. The patch 
executes `db_setup.py -javapatch`, so I'd expect that since it's done on the 
database that you'd only want it done once. But you'd also want all of them 
down.

With that said, I still don't understand why this is being done post-upgrade.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137042
-----------------------------------------------------------


On June 10, 2016, 8:47 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> -----------------------------------------------------------
> 
> (Updated June 10, 2016, 8:47 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
>     https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> -------
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to