-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48590/#review137228
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On June 12, 2016, 10:57 p.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48590/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 10:57 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17179
>     https://issues.apache.org/jira/browse/AMBARI-17179
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - AMBARI-17179. Allow 'LLAP related calculations' to be done for any selected 
> queue instead of existing for only 'llap' named queue.
> 
>      - With this change, LLAP config calculation code will do calculations 
> for any queue selected (Given that selected queue capacity is enough to do 
> caluclations).
>      - Further, if any selected queue capacity is < minimum required queue 
> capacity for LLAP/HIVE2 to work, a validation error will pop up at the SAVE 
> operation.
>          Screenshot acttached.
>         -> 2 validations added : 1. When selectd queue is in STOPPED state. 
> 2. When selected queue size is less than minimum required for LLAP app to 
> run. 
>         -> This will serve as a feedback to the user to increase the capacity 
> of the selected queue or select a different queue for the operation.
>         -> **Point to note :** A slider for changing the queue capacity will 
> only be available if 'llap' queue is selected. For any other queue selected 
>            from dropdown, any capacity change related operation, user will 
> have to go via already known means of altering the capacity (eg: CapSched 
> View).
>            
>            
>            
> - Also fixes the following issues :
> - 
>    
>      - Normalizing up the calculated value for 'Slider AM Container Size' 
> with YARN Minimum Container Size in fn. updateLlapConfigs(). 
>      
>        
>      - 'hive.llap.io.threadpool.size' config value is now set same as value 
> calculated for 'hive.llap.daemon.num.executors' at all times.
>      
>      
>      - Updates the 2.5/services/HIVE/themes/theme.json, to allow 
> 'llap_queue_capacity' slider visibility to be set via recommendation from 
> stack_advisor.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> c2fd8a7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  6f806d2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  ac92b86 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json
>  1922b79 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> df6c65c 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-2-hosts.json
>  dcf6d26 
>   
> ambari-server/src/test/python/stacks/2.5/common/services-normal-his-valid.json
>  69c7e55 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 5a54548 
> 
> Diff: https://reviews.apache.org/r/48590/diff/
> 
> 
> Testing
> -------
> 
> - Python UT's added and modifed.
> - Python UT passes.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2016-06-12 at 3.46.48 PM.png
>   
> https://reviews.apache.org/media/uploaded/files/2016/06/12/9e2997f5-2d81-410a-b84a-1e313800e4c2__Screen_Shot_2016-06-12_at_3.46.48_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to