> On June 7, 2016, 6:49 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py,
> >  line 130
> > <https://reviews.apache.org/r/48044/diff/6/?file=1408744#file1408744line130>
> >
> >     Please consult with Jayush Luniya.
> >     The stack already has a config for the stack root, so hdp_select (or 
> > distro select as it should be called) shouldn't be hardcoding paths.

This patch is for 2.2-next branch that doesn't have those improvements. (Tried 
to do this following one of your previous notes - seems that those weren't 
backported to this branch)


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review136517
-----------------------------------------------------------


On June 13, 2016, 8:28 a.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 8:28 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Daniel Gergely, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
>     https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installation related information.
> 
> The patch only applies for 2.2-next versions.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Reply via email to