-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sid Wagle.


Bugs: AMBARI-17184
    https://issues.apache.org/jira/browse/AMBARI-17184


Repository: ambari


Description
-------

When we wanted to restart HBase, we got an error
```
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
 line 159, in <module>
    HbaseMaster().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 257, in execute
    method(env)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 686, in restart
    self.start(env, upgrade_type=upgrade_type)
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
 line 86, in start
    self.configure(env) # for security
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py",
 line 41, in configure
    hbase(name='master')
  File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
line 89, in thunk
    return fn(*args, **kwargs)
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
 line 166, in hbase
    tag = 'GANGLIA-MASTER' if name == 'master' else 'GANGLIA-RS'
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py",
 line 233, in hbase_TemplateConfig
    template_tag = tag
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
    self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
    self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
    provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/providers/template_config.py",
 line 46, in action_create
    content = Template(template_name, extra_imports=self.resource.extra_imports)
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
    self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
    self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
    provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 123, in action_create
    content = self._get_content()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 160, in _get_content
    return content()
  File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
line 51, in __call__
    return self.get_content()
  File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", 
line 142, in get_content
    rendered = self.template.render(self.context)
  File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 
891, in render
    return self.environment.handle_exception(exc_info, True)
  File 
"/var/lib/ambari-agent/cache/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-MASTER.j2",
 line 76, in top-level template code
    hbase.sink.timeline.truststore.password = {{metric_truststore_password}}
ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
```


We should define metric_collector_hosts in 
ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py


Diffs
-----

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 05bad1c 

Diff: https://reviews.apache.org/r/48628/diff/


Testing
-------

mvn clean test && manual test


Thanks,

Masahiro Tanaka

Reply via email to