-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48642/#review137311
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 
(line 497)
<https://reviews.apache.org/r/48642/#comment202477>

    Could you also add a comment, like this may happen in case of Ambari server 
actions for s Kerberized clusters. Also in case role = 'AMBARI_SEVER_ACTION' we 
may not even log anything, beacuse that's normal behavoir.


- Sandor Magyari


On June 13, 2016, 3:04 p.m., Daniel Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48642/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 3:04 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Levas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-17196
>     https://issues.apache.org/jira/browse/AMBARI-17196
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When creating a cluster with kerberos, ambari-server.out contains 
> NullPointerExceptions, because kerberos related AMBARI_SERVER_ACTIONs do not 
> belong to logical tasks.
> NPE source is a Long->long conversion when logical task id is null when 
> AMBARI_SERVER_ACTION is tried to be retrieved from logicalTaskMap.
> 
> The fix is a NPE check that skips the registerPhysicalTaskId method. I added 
> it also to the StartHostsTask class.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  00ecb98 
> 
> Diff: https://reviews.apache.org/r/48642/diff/
> 
> 
> Testing
> -------
> 
> Changes are done in private classes, so they cannot be accessed from unit 
> tests.
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Reply via email to