> On June 13, 2016, 6:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java,
> >  line 2440
> > <https://reviews.apache.org/r/48624/diff/1/?file=1416653#file1416653line2440>
> >
> >     Move these properties out of the for-loop.
> >     If they are empty, should be be an error instead of a "continue"

These are the instance properties, as we are iterating over instances these 
cannot be move out of for-loop. 
Ideally this should never happen. It can happen only when custom configured 
instance is in bad state. In this case, the view instance is not working before 
upgrade and we are skipping the upgrade for it instead of aborting upgrade.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48624/#review137351
-----------------------------------------------------------


On June 13, 2016, 9:41 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48624/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 9:41 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17188
>     https://issues.apache.org/jira/browse/AMBARI-17188
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Upgrade cluster_handle column to have current cluster_id if it is not null.
> Check null or empty configuration properties for custom capacity scheduler 
> view.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  7451bbe 
> 
> Diff: https://reviews.apache.org/r/48624/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to