----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48568/#review137356 -----------------------------------------------------------
Ship it! Ship It! - Jaimin Jetly On June 11, 2016, 12:01 a.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48568/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 12:01 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17176 > https://issues.apache.org/jira/browse/AMBARI-17176 > > > Repository: ambari > > > Description > ------- > > We need to include the Default Version Definition in the list of dropdown > Versions along with the discovered versions. > Current experience: we only include Default if we believe we do not have > internet access > New experience: include Default in the list regardless of internet or not. > This is for backwards compatibility, and in the case where the user "just > does not know" their version (and therefore, needs Ambari to just figure it > out best it can). > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 5433bd6 > ambari-web/app/controllers/wizard/step1_controller.js 3af28de > ambari-web/app/templates/wizard/step1.hbs 59ff21b > > Diff: https://reviews.apache.org/r/48568/diff/ > > > Testing > ------- > > ambari-web: > 28670 tests complete (24 seconds) > 154 tests pending > ambari-admin: > Executed 71 of 71 SUCCESS (0.142 secs / 0.356 secs) > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
