----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48557/#review137357 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On June 13, 2016, 9:22 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48557/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 9:22 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sumit Mohanty. > > > Bugs: AMBARI-17112 > https://issues.apache.org/jira/browse/AMBARI-17112 > > > Repository: ambari > > > Description > ------- > > Patch implements logic for on-ambari-upgrade attributes: add, update, delete > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java > de5147d > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > c570ab3 > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java > f6791ee > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 3ee8bba > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml > 6793e4e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > fd68ae0 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-startup.properties.xml > aacf10a > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml > 4e56084 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/core-site.xml > 7f67b8a > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml > 274163e > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml > b0f36e7 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/webhcat-site.xml > 444b8b4 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-broker.xml > cfdd989 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml > 7f474f6 > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-plugin-properties.xml > f3a6bcf > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/configuration/ranger-knox-plugin-properties.xml > 47c900e > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml > a309fa4 > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml > 2d0047c > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > 5082277 > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/admin-properties.xml > 121a797 > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-env.xml > ae56f8b > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-site.xml > 4317cfa > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/usersync-properties.xml > 7eb78e5 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/admin-properties.xml > a747dde > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml > 35910ee > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 6eb312f > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml > 9870b8b > > ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-defaults.xml > 633cbda > > ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-thrift-sparkconf.xml > daacdee > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-plugin-properties.xml > 21cd096 > > ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-site.xml > a8f1584 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml > d7c87e9 > > ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/ranger-storm-plugin-properties.xml > 7aa18cc > > ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml > fcaecaa > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml > 85a1eba > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/capacity-scheduler.xml > b4fedd8 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml > b1b30aa > ambari-server/src/main/resources/configuration-schema.xsd 6716dd5 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml > 8dc02c5 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml > 7e746c0 > > ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-site.xml > 463dd6b > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/hbase-site.xml > f92bc1a > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > ca50414 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > 231d430 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml > accc630 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/ranger-hive-plugin-properties.xml > 4e29675 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/capacity-scheduler.xml > 7443771 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml > 56b8839 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-site.xml > 1016af5 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-plugin-properties.xml > 81ca4ca > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml > 21cd096 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/hive-site.xml > 615ba3d > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-plugin-properties.xml > 81ca4ca > > ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-plugin-properties.xml > 21cd096 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/capacity-scheduler.xml > 87558c0 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-site.xml > 0d9b5bb > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml > 985b4cf > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml > fcaecaa > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml > d0bb858 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml > fcaecaa > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml > fcaecaa > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/configuration/ranger-knox-audit.xml > fcaecaa > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml > 8348c3e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml > a7833cf > > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/ranger-yarn-audit.xml > fcaecaa > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-env.xml > 8b26e18 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-hbase-env.xml > d1669aa > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/FALCON/configuration/falcon-env.xml > e842122 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/configuration/hbase-env.xml > 9282ef7 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/configuration/hbase-site.xml > aa6e310 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HDFS/configuration/hadoop-env.xml > 18350f8 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HDFS/configuration/hdfs-site.xml > 8e1c599 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HIVE/configuration/hive-env.xml > c858dcc > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/OOZIE/configuration/oozie-env.xml > ab84e00 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/SQOOP/configuration/sqoop-env.xml > e3f52c8 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/configuration/storm-env.xml > 83d1e8d > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml > f573623 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-env.xml > 852632a > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/yarn-env.xml > dc67a81 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/ZOOKEEPER/configuration/zookeeper-env.xml > 6e34ea8 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HBASE/configuration/hbase-site.xml > 571d4c2 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-env.xml > 2a808cd > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml > be17f65 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml > 354bf86 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration-mapred/mapred-site.xml > cc04c63 > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HBASE/configuration/hbase-site.xml > afdb672 > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-env.xml > 399aecc > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/OOZIE/configuration/oozie-site.xml > 7bcc994 > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/STORM/configuration/storm-site.xml > 14ef896 > > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/YARN/configuration/capacity-scheduler.xml > bbee4a5 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java > PRE-CREATION > > ambari-server/src/test/resources/bad-stacks/HDP/0.1/services/YARN/configuration/capacity-scheduler.xml > f938677 > > ambari-server/src/test/resources/bad-stacks/HDP/0.1/services/YARN/configuration/yarn-site.xml > 1efe20c > > ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml > 0d500e9 > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/configuration/yarn-site.xml > d68478f > > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/configuration/hdfs-site.xml > 6e736ff > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/HDFS/configuration/hdfs-site.xml > 6e736ff > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/services/HDFS/configuration/hdfs-site.xml > 6e736ff > > Diff: https://reviews.apache.org/r/48557/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >