-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/#review137377
-----------------------------------------------------------



Has this been tested on an actual stack? These configs are being added to HDP 
2.3 or higher.
For an existing cluster with HDP 2.3 or higher, I believe ambari upgrade will 
add this as a new config type.


ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
 (line 28)
<https://reviews.apache.org/r/48609/#comment202515>

    Based on the latest code, we no longer need <on-stack-upgrade .../>
    
    I believe you want,
    <on-ambari-upgrade add="true" /> and take any other defaults.


- Alejandro Fernandez


On June 13, 2016, 4:02 a.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48609/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 4:02 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-17183
>     https://issues.apache.org/jira/browse/AMBARI-17183
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently falcon-client.properties is generated without functionality for 
> user changes.   We should fix it for users of mirroring etc
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  5e25325 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  8c2ad8e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
>  9a72af1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48609/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Reply via email to