----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48654/#review137379 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java (line 75) <https://reviews.apache.org/r/48654/#comment202517> This is probably for the best as the Jackson and Gson parsers used for the REST API and agents keep turning this into 0.0 ... Of course, if we used objects and not wonk Map<Map<Map<Map ... we wouldn't need to worry about it. Thanks for making this more robust! - Jonathan Hurley On June 13, 2016, 4:57 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48654/ > ----------------------------------------------------------- > > (Updated June 13, 2016, 4:57 p.m.) > > > Review request for Ambari, Dmytro Sen and Jonathan Hurley. > > > Bugs: AMBARI-17202 > https://issues.apache.org/jira/browse/AMBARI-17202 > > > Repository: ambari > > > Description > ------- > > When upgrading from earlier versions of Ambari, the alert definitions do not > include some of the new parameters / connection timeout values which were > added to the alert definitions. This is normally OK since the alert framework > has sensible defaults of the values are not specified. > However, it was observed on Ambari 2.2.2 that the web client wasn't able to > properly render/save the values. > STR: > Install Ambari 2.2.0 > Upgrade to Ambari 2.2.2 > You should now have alert definitions, such as DataNode Web UI, which do not > have a connection_timeout value. > Navigate to the DataNode Web UI alert definition page and notice that you are > not able to update and save the "Connection Timeout" property correctly. > Attachments > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java > c269927 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 3ee8bba > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 7451bbe > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > c221138 > > Diff: https://reviews.apache.org/r/48654/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
