-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48490/#review137465
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
 (line 98)
<https://reviews.apache.org/r/48490/#comment202610>

    Boolean.parseBoolean never returns null, the return value is false if the 
input is null.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 (line 132)
<https://reviews.apache.org/r/48490/#comment202611>

    Boolean.parseBoolean never returns null, the return value is false if the 
input is null.



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
 (line 35)
<https://reviews.apache.org/r/48490/#comment202608>

    Why not using camel case for filter name?


- Miklos Gergely


On June 13, 2016, 6:36 a.m., Dharmesh Makwana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48490/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 6:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Jaimin Jetly, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17140
>     https://issues.apache.org/jira/browse/AMBARI-17140
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch contains
> 1) Last button in the log search pagination panel does not take the user to 
> the last page.
> 2) Solr warming feature added.
> 3) Suffix in columns mapping issue fixed.
> 
> 
> Diffs
> -----
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  917956f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditMgr.java
>  53e386e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  ca63671 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/MgrBase.java
>  1d069d3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  3b23f2a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGeneration.java
>  4647c7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditREST.java
>  92bfb01 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/DashboardREST.java
>  1e107ed 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/ConfigUtil.java
>  44d184d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VUserConfig.java
>  55ec1c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/default.properties
>  25b4f1a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/META-INF/applicationContext.xml
>  6a73d60 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/collections/BaseCollection.js
>  24b6974 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js
>  869a1d4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
>  5f93c5a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dialog/ApplySearchFilterView.js
>  4babebc 
> 
> Diff: https://reviews.apache.org/r/48490/diff/
> 
> 
> Testing
> -------
> 
> Setup Logsearch on 2 node cluster and tested the above feature.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Reply via email to